]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
orangefs: Do not truncate file size
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 5 Mar 2025 20:47:25 +0000 (20:47 +0000)
committerChristian Brauner <brauner@kernel.org>
Thu, 6 Mar 2025 08:26:06 +0000 (09:26 +0100)
'len' is used to store the result of i_size_read(), so making 'len'
a size_t results in truncation to 4GiB on 32-bit systems.

Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Link: https://lore.kernel.org/r/20250305204734.1475264-2-willy@infradead.org
Tested-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/orangefs/inode.c

index aae6d2b8767df04714647db5fe1e5ce54c092fce..63d7c1ca0dfd35c90bb5e7728bb55e4275677333 100644 (file)
@@ -23,9 +23,9 @@ static int orangefs_writepage_locked(struct page *page,
        struct orangefs_write_range *wr = NULL;
        struct iov_iter iter;
        struct bio_vec bv;
-       size_t len, wlen;
+       size_t wlen;
        ssize_t ret;
-       loff_t off;
+       loff_t len, off;
 
        set_page_writeback(page);
 
@@ -91,8 +91,7 @@ static int orangefs_writepages_work(struct orangefs_writepages *ow,
        struct orangefs_write_range *wrp, wr;
        struct iov_iter iter;
        ssize_t ret;
-       size_t len;
-       loff_t off;
+       loff_t len, off;
        int i;
 
        len = i_size_read(inode);