]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
[mod_sofia] coverity CID 1024253 (Dereference before null check)
authorDragos Oancea <dragos@signalwire.com>
Wed, 31 May 2023 13:10:36 +0000 (16:10 +0300)
committerAndrey Volk <andywolk@gmail.com>
Wed, 31 May 2023 21:43:07 +0000 (00:43 +0300)
src/mod/endpoints/mod_sofia/mod_sofia.c

index 0b74b89c9da5ff6887f7043848946f3dc31892b5..7c6f42f38b424845ad9b480701c64f1a19e49ddb 100644 (file)
@@ -4313,6 +4313,8 @@ SWITCH_STANDARD_API(sofia_presence_data_function)
                user = argv[1];
        }
 
+       if (!user) goto end;
+
        if ((domain = strchr(user, '@'))) {
                *domain++ = '\0';
                if ((concat = strchr(domain, '/'))) {
@@ -4329,8 +4331,6 @@ SWITCH_STANDARD_API(sofia_presence_data_function)
                domain = dup_domain;
        }
 
-       if (!user) goto end;
-
        if (zstr(profile_name) || strcmp(profile_name, "*") || zstr(domain)) {
                if (!zstr(profile_name)) {
                        profile = sofia_glue_find_profile(profile_name);