- setting echo=False on create_engine() now sets the loglevel

to WARN instead of NOTSET.  This so that logging can be
disabled for a particular engine even if logging
for "sqlalchemy.engine" is enabled overall.  Note that the
default setting of "echo" is `None`. [ticket:1554]

diff --git a/CHANGES b/CHANGES
index f2549eca29ff94995317bc57e9d155d1f99e80bc..0db98ae60dbe156a55030bbb750d188c73785bb5 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -156,6 +156,12 @@ CHANGES
   - RowProxy objects are now pickleable, i.e. the object returned
     by result.fetchone(), result.fetchall() etc.
 
+  - setting echo=False on create_engine() now sets the loglevel
+    to WARN instead of NOTSET.  This so that logging can be
+    disabled for a particular engine even if logging
+    for "sqlalchemy.engine" is enabled overall.  Note that the
+    default setting of "echo" is `None`. [ticket:1554]
+    
 - schema
     - deprecated MetaData.connect() and
       ThreadLocalMetaData.connect() have been removed - send

diff --git a/lib/sqlalchemy/log.py b/lib/sqlalchemy/log.py
index e7abaed3ff8ba6e3880e28cbe8cc3829a8c2bf69..b20e116cff8a59d92beb6f41e6b55f9299d09547 100644 (file)
--- a/lib/sqlalchemy/log.py
+++ b/lib/sqlalchemy/log.py
@@ -82,7 +82,7 @@ def instance_logger(instance, echoflag=None):
             default_logging(name)
             l.setLevel(logging.INFO)
         elif echoflag is False:
-            l.setLevel(logging.NOTSET)
+            l.setLevel(logging.WARN)
     else:
         l = logging.getLogger(name)
     instance._should_log_debug = l.isEnabledFor(logging.DEBUG)