]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (max6639) Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 11:07:04 +0000 (12:07 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 31 Jan 2026 15:38:32 +0000 (07:38 -0800)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251224110702.61746-5-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/max6639.c

index 99140a2ca9955ebbf4d1d97f76c90270f3589881..a0a1dbbda8871e332f75a871b8c9304f358623b4 100644 (file)
@@ -563,7 +563,6 @@ static int max6639_init_client(struct i2c_client *client,
 {
        struct device *dev = &client->dev;
        const struct device_node *np = dev->of_node;
-       struct device_node *child;
        int i, err;
        u8 target_duty;
 
@@ -582,15 +581,13 @@ static int max6639_init_client(struct i2c_client *client,
        data->target_rpm[0] = 4000;
        data->target_rpm[1] = 4000;
 
-       for_each_child_of_node(np, child) {
+       for_each_child_of_node_scoped(np, child) {
                if (strcmp(child->name, "fan"))
                        continue;
 
                err = max6639_probe_child_from_dt(client, child, data);
-               if (err) {
-                       of_node_put(child);
+               if (err)
                        return err;
-               }
        }
 
        for (i = 0; i < MAX6639_NUM_CHANNELS; i++) {