]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
test(transition): add invalid durations test case (#1702)
authorChe Guevara <836934184@qq.com>
Tue, 28 Jul 2020 19:36:36 +0000 (03:36 +0800)
committerGitHub <noreply@github.com>
Tue, 28 Jul 2020 19:36:36 +0000 (15:36 -0400)
packages/vue/__tests__/Transition.spec.ts

index 0c124d182c44507981054971b318d7386f9d50a1..70f038609ba7de3d1d7982a3757fff0a093569c8 100644 (file)
@@ -1799,7 +1799,41 @@ describe('e2e: Transition', () => {
       E2E_TIMEOUT
     )
 
-    // fixme
-    test.todo('warn invalid durations')
+    test(
+      'warn invalid durations',
+      async () => {
+        createApp({
+          template: `
+            <div id="container">
+              <transition name="test" :duration="NaN">
+                <div class="test">content</div>
+              </transition>
+            </div>
+          `
+        }).mount(document.createElement('div'))
+        expect(
+          `[Vue warn]: <transition> explicit duration is NaN - ` +
+            'the duration expression might be incorrect.'
+        ).toHaveBeenWarned()
+
+        createApp({
+          template: `
+            <div id="container">
+              <transition name="test" :duration="{
+                enter: {},
+                leave: {}
+              }">
+                <div class="test">content</div>
+              </transition>
+            </div>
+          `
+        }).mount(document.createElement('div'))
+        expect(
+          `[Vue warn]: <transition> explicit duration is not a valid number - ` +
+            `got ${JSON.stringify({})}`
+        ).toHaveBeenWarned()
+      },
+      E2E_TIMEOUT
+    )
   })
 })