]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU
authorStephan Gerhold <stephan.gerhold@linaro.org>
Wed, 19 Feb 2025 11:36:21 +0000 (12:36 +0100)
committerBjorn Andersson <andersson@kernel.org>
Tue, 4 Mar 2025 04:14:48 +0000 (22:14 -0600)
There are currently two passive trip points defined for the CPU, but no
cooling devices are attached to the thermal zones. We don't have support
for cpufreq upstream yet, but actually this is redundant anyway because the
CPU is throttled automatically when reaching high temperatures.

Drop the passive trip points and keep just the critical shutdown as safety
measure in case the throttling fails.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20250219-x1e80100-thermal-fixes-v1-4-d110e44ac3f9@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100.dtsi

index 9382a2fce2f34eedcee172be965ccef34cacc111..46b79fce92c90d969e3de48bc88e27915d1592bb 100644 (file)
                };
 
                cpu0-0-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 1>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-0-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 2>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-1-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 3>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-1-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 4>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-2-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 5>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-2-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 6>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-3-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 7>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu0-3-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens0 8>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens0 9>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens0 10>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-0-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 1>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-0-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 2>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-1-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 3>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-1-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 4>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-2-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 5>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-2-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 6>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-3-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 7>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu1-3-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens1 8>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens1 9>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens1 10>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-0-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 1>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-0-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 2>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-1-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 3>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-1-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 4>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-2-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 5>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-2-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 6>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-3-top-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 7>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                };
 
                cpu2-3-btm-thermal {
-                       polling-delay-passive = <250>;
-
                        thermal-sensors = <&tsens2 8>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
-                               trip-point1 {
-                                       temperature = <95000>;
-                                       hysteresis = <2000>;
-                                       type = "passive";
-                               };
-
                                cpu-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens2 9>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;
                        thermal-sensors = <&tsens2 10>;
 
                        trips {
-                               trip-point0 {
-                                       temperature = <90000>;
-                                       hysteresis = <2000>;
-                                       type = "hot";
-                               };
-
                                cpuss2-critical {
                                        temperature = <115000>;
                                        hysteresis = <1000>;