]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libblkid: clarify operation order [cppcheck]
authorSami Kerola <kerolasa@iki.fi>
Tue, 7 Feb 2012 21:14:34 +0000 (22:14 +0100)
committerKarel Zak <kzak@redhat.com>
Wed, 8 Feb 2012 13:05:39 +0000 (14:05 +0100)
[libblkid/src/cache.c:265]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
libblkid/src/cache.c

index 2eab2d3292bc2342838319e90953f014f6826b49..a60495aa50e3053f6147419cdc7f39177261419f 100644 (file)
@@ -262,7 +262,7 @@ int main(int argc, char** argv)
                        argv[0], ret);
                exit(1);
        }
-       if ((ret = blkid_probe_all(cache) < 0))
+       if ((ret = blkid_probe_all(cache)) < 0)
                fprintf(stderr, "error probing devices\n");
 
        blkid_put_cache(cache);