]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
evh__new_mem_heap: get rid of pointless conditional. Spotted by
authorJulian Seward <jseward@acm.org>
Fri, 5 Sep 2014 20:29:10 +0000 (20:29 +0000)
committerJulian Seward <jseward@acm.org>
Fri, 5 Sep 2014 20:29:10 +0000 (20:29 +0000)
Coverity and Florian Krohm.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14472

helgrind/hg_main.c

index 46f64e3901635f8df549a101682f922f66e59b41..ef3104140469e01321f6c55867b2fdba561d5a49 100644 (file)
@@ -1794,12 +1794,8 @@ void evh__new_mem_heap ( Addr a, SizeT len, Bool is_inited ) {
    if (SHOW_EVENTS >= 1)
       VG_(printf)("evh__new_mem_heap(%p, %lu, inited=%d)\n", 
                   (void*)a, len, (Int)is_inited );
-   // FIXME: this is kinda stupid
-   if (is_inited) {
-      shadow_mem_make_New(get_current_Thread(), a, len);
-   } else {
-      shadow_mem_make_New(get_current_Thread(), a, len);
-   }
+   // We ignore the initialisation state (is_inited); that's ok.
+   shadow_mem_make_New(get_current_Thread(), a, len);
    if (len >= SCE_BIGRANGE_T && (HG_(clo_sanity_flags) & SCE_BIGRANGE))
       all__sanity_check("evh__pre_mem_read-post");
 }