]> git.ipfire.org Git - thirdparty/rsync.git/commitdiff
Fix warning about conflicting lseek/lseek64 prototypes
authorHolger Hoffstätte <holger@applied-asynchrony.com>
Mon, 4 Sep 2023 12:07:14 +0000 (14:07 +0200)
committerWayne Davison <wayne@opencoder.net>
Wed, 20 Nov 2024 05:28:39 +0000 (21:28 -0800)
Clang rightfully complains about conflicting prototypes, as both lseek() variants
are redefined:

  syscall.c:394:10: warning: a function declaration without a prototype is deprecated
  in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting
  with a previous declaration [-Wdeprecated-non-prototype]
        off64_t lseek64();
                ^
/usr/include/unistd.h:350:18: note: conflicting prototype is here
extern __off64_t lseek64 (int __fd, __off64_t __offset, int __whence)
                 ^
1 warning generated.

The point of the #ifdef is to build for the configured OFF_T; there is
no reason to redefine lseek/lseek64, which should have been found
via configure.

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
syscall.c

index d92074aaadc20f595c6d381a24d6eefb0f90d416..b4b0f1f16d7175b915502349607d52cf3e6fb28e 100644 (file)
--- a/syscall.c
+++ b/syscall.c
@@ -388,11 +388,6 @@ int do_fstat(int fd, STRUCT_STAT *st)
 OFF_T do_lseek(int fd, OFF_T offset, int whence)
 {
 #ifdef HAVE_LSEEK64
-#if !SIZEOF_OFF64_T
-       OFF_T lseek64();
-#else
-       off64_t lseek64();
-#endif
        return lseek64(fd, offset, whence);
 #else
        return lseek(fd, offset, whence);