2005-12-25 Marco Gerards <marco@gnu.org>

	* kern/env.c (grub_env_set): Rewritten the error handling code.

diff --git a/ChangeLog b/ChangeLog
index 719fc732b72ae6c96b1d4993800dff3a03e542ce..5fd92d3c7b960de68d124bb6e22d19bd90f3cb8c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2005-12-25  Marco Gerards  <marco@gnu.org>
+
+       * kern/env.c (grub_env_set): Rewritten the error handling code.
+
 2005-12-25  Yoshinori K. Okuji  <okuji@enbug.org>
 
        * geninit.sh: Made more robust, and more portable.

diff --git a/kern/env.c b/kern/env.c
index 449275f23aa59b6281c8006e9bdd006f881ae6c8..f952422c8a3c85f55338fc049aec953cb488024b 100644 (file)
--- a/kern/env.c
+++ b/kern/env.c
@@ -123,15 +123,14 @@ grub_env_set (const char *var, const char *val)
     sort->sort_prevp = &env->sort_next;
   *sortp = env;
 
- fail:
-  if (grub_errno)
-    {
-      grub_free (env->name);
-      grub_free (env->value);
-      grub_free (env);
-    }
-  
   return 0;
+
+ fail:
+  grub_free (env->name);
+  grub_free (env->value);
+  grub_free (env);
+
+  return grub_errno;
 }
 
 char *