]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ethernet: mtk_eth_soc: only use legacy mode on missing IRQ name
authorFrank Wunderlich <frank-w@public-files.de>
Thu, 19 Jun 2025 13:21:24 +0000 (15:21 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Jun 2025 01:14:01 +0000 (18:14 -0700)
If platform_get_irq_byname returns -ENXIO fall back to legacy (index
based) mode, but on other errors function should return this error.

Suggested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250619132125.78368-5-linux@fw-web.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 67ba8927be4689c78055a45f1592fcc8e7c883ba..f8a907747db419ccb06aafc0dc972abadf6d1124 100644 (file)
@@ -3346,6 +3346,13 @@ static int mtk_get_irqs(struct platform_device *pdev, struct mtk_eth *eth)
        if (eth->irq[MTK_FE_IRQ_TX] >= 0 && eth->irq[MTK_FE_IRQ_RX] >= 0)
                return 0;
 
+       /* only use legacy mode if platform_get_irq_byname returned -ENXIO */
+       if (eth->irq[MTK_FE_IRQ_TX] != -ENXIO)
+               return eth->irq[MTK_FE_IRQ_TX];
+
+       if (eth->irq[MTK_FE_IRQ_RX] != -ENXIO)
+               return eth->irq[MTK_FE_IRQ_RX];
+
        /* legacy way:
         * On MTK_SHARED_INT SoCs (MT7621 + MT7628) the first IRQ is taken
         * from devicetree and used for both RX and TX - it is shared.