]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Remove return value from virQEMUCapsHostCPUDataCopy
authorPeter Krempa <pkrempa@redhat.com>
Fri, 3 Mar 2023 09:34:58 +0000 (10:34 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 6 Mar 2023 19:55:50 +0000 (20:55 +0100)
The function can't fail at this point. Remove the last outstanding
pointless error check and turn the return type into 'void'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_capabilities.c

index 9cc8d999941d8bd0804443215b9c0e3c0e2ea542..5d3ab3b95852215086825caa7111f60e25e992b6 100644 (file)
@@ -1848,13 +1848,12 @@ virQEMUCapsNewBinary(const char *binary)
 }
 
 
-static int
+static void
 virQEMUCapsHostCPUDataCopy(virQEMUCapsHostCPUData *dst,
                            virQEMUCapsHostCPUData *src)
 {
-    if (src->info &&
-        !(dst->info = qemuMonitorCPUModelInfoCopy(src->info)))
-        return -1;
+    if (src->info)
+        dst->info = qemuMonitorCPUModelInfoCopy(src->info);
 
     if (src->reported)
         dst->reported = virCPUDefCopy(src->reported);
@@ -1864,8 +1863,6 @@ virQEMUCapsHostCPUDataCopy(virQEMUCapsHostCPUData *dst,
 
     if (src->full)
         dst->full = virCPUDefCopy(src->full);
-
-    return 0;
 }
 
 
@@ -1968,8 +1965,7 @@ virQEMUCapsAccelCopy(virQEMUCapsAccel *dst,
 {
     virQEMUCapsAccelCopyMachineTypes(dst, src);
 
-    if (virQEMUCapsHostCPUDataCopy(&dst->hostCPU, &src->hostCPU) < 0)
-        return -1;
+    virQEMUCapsHostCPUDataCopy(&dst->hostCPU, &src->hostCPU);
 
     dst->cpuModels = qemuMonitorCPUDefsCopy(src->cpuModels);