[misc] Use new `get()` more (#2659)

- Use it in `getSetDayOfWeek`
- Also update style and comments for commented out `set()` cases

diff --git a/src/lib/moment/get-set.js b/src/lib/moment/get-set.js
index d6a7f6690d50c865d372b5affc029607eb72d160..526740f4987dfaa9ab36dc8407a0ecaf46e524a4 100644 (file)
--- a/src/lib/moment/get-set.js
+++ b/src/lib/moment/get-set.js
@@ -35,7 +35,8 @@ export function get(mom, unit) {
             return isUTC ? d.getUTCHours() : d.getHours();
         case 'Date':
             return isUTC ? d.getUTCDate() : d.getDate();
-        // case 'Day': return isUTC ? d.getUTCDay() : d.getDay(); // Not used
+        case 'Day':
+            return isUTC ? d.getUTCDay() : d.getDay();
         case 'Month':
             return isUTC ? d.getUTCMonth() : d.getMonth();
         case 'FullYear':
@@ -68,8 +69,10 @@ export function set(mom, unit, value) {
             return void (isUTC ? d.setUTCHours(value) : d.setHours(value));
         case 'Date':
             return void (isUTC ? d.setUTCDate(value) : d.setDate(value));
-        // case 'Day': return void (isUTC ? d.setUTCDay(value) : d.setDay(value)); // Not real
-        // case 'Month': return void (isUTC ? d.setUTCMonth(value) : d.setMonth(value)); // Not used
+        // case 'Day': // Not real
+        //    return void (isUTC ? d.setUTCDay(value) : d.setDay(value));
+        // case 'Month': // Not used because we need to pass two variables
+        //     return void (isUTC ? d.setUTCMonth(value) : d.setMonth(value));
         case 'FullYear':
             break; // See below ...
         default:

diff --git a/src/lib/units/day-of-week.js b/src/lib/units/day-of-week.js
index 7d5d038aa9352dcf26af0a61906a7af915bb9798..4cdc4d4a87e711a1cf0721a4d377be8f5ffeb80a 100644 (file)
--- a/src/lib/units/day-of-week.js
+++ b/src/lib/units/day-of-week.js
@@ -1,3 +1,4 @@
+import { get } from '../moment/get-set';
 import { addFormatToken } from '../format/format';
 import {
     addRegexToken,
@@ -283,7 +284,8 @@ export function getSetDayOfWeek(input) {
     if (!this.isValid()) {
         return input != null ? this : NaN;
     }
-    var day = this._isUTC ? this._d.getUTCDay() : this._d.getDay();
+
+    var day = get(this, 'Day');
     if (input != null) {
         input = parseWeekday(input, this.localeData());
         return this.add(input - day, 'd');