]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: attribute scrub should use seen_enough to pass error values
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 14 Aug 2019 22:05:17 +0000 (18:05 -0400)
committerEric Sandeen <sandeen@redhat.com>
Wed, 14 Aug 2019 22:05:17 +0000 (18:05 -0400)
Source kernel commit: 2c3b83d7ca6d73b9478afc86c89377c15a90b9ed

When we're iterating all the attributes using the built-in xattr
iterator, we can use the seen_enough variable to pass error codes back
to the main scrub function instead of flattening them into 0/1.  This
will be used in a more exciting fashion in upcoming patches.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_attr.h

index 3b0dce06e454f265eb7e97bb5712f0e10639e286..ff28ebf3b635d1940f1306006623a072602ecd5f 100644 (file)
@@ -112,7 +112,13 @@ typedef struct xfs_attr_list_context {
        struct xfs_inode                *dp;            /* inode */
        struct attrlist_cursor_kern     *cursor;        /* position in list */
        char                            *alist;         /* output buffer */
-       int                             seen_enough;    /* T/F: seen enough of list? */
+
+       /*
+        * Abort attribute list iteration if non-zero.  Can be used to pass
+        * error values to the xfs_attr_list caller.
+        */
+       int                             seen_enough;
+
        ssize_t                         count;          /* num used entries */
        int                             dupcnt;         /* count dup hashvals seen */
        int                             bufsize;        /* total buffer size */