]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
tools: Fix strncpy() truncation warning
authorTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:50:53 +0000 (16:50 +0000)
committerTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:52:08 +0000 (16:52 +0000)
Fix the following strncpy() string truncation warning:

In function ‘strncpy’,
    inlined from ‘parse_cgroup_spec’ at ../tools/tools-common.c:92:2:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 4096 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/tools/tools-common.c

index 211a49a93e6a54155fd2c4ebdc8b124ef2771923..4b0efa8b216b4d7acf8871c605a4cfb7a92d0c0c 100644 (file)
@@ -89,8 +89,8 @@ int parse_cgroup_spec(struct cgroup_group_spec **cdptr, char *optarg,
        } while (temp && j<CG_CONTROLLER_MAX-1);
 
        /* Store path to the cgroup */
-       strncpy(cdptr[i]->path, pathptr, FILENAME_MAX);
-       cdptr[i]->path[FILENAME_MAX-1] = '\0';
+       strncpy(cdptr[i]->path, pathptr, FILENAME_MAX - 1);
+       cdptr[i]->path[sizeof(cdptr[i]->path) - 1] = '\0';
 
        return 0;
 }