]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
iselStmt, case Ist_Dirty: remove pointless conditional. Spotted by
authorJulian Seward <jseward@acm.org>
Fri, 5 Sep 2014 20:38:34 +0000 (20:38 +0000)
committerJulian Seward <jseward@acm.org>
Fri, 5 Sep 2014 20:38:34 +0000 (20:38 +0000)
Coverity and Florian Krohm.

git-svn-id: svn://svn.valgrind.org/vex/trunk@2945

VEX/priv/host_ppc_isel.c

index f58e1a2d2795510d5d71ebd4622cfef1705cab7c..91f5620160b97c678b1fb03250dba96aef17e30f 100644 (file)
@@ -5761,26 +5761,18 @@ static void iselStmt ( ISelEnv* env, IRStmt* stmt, IREndness IEndianess )
       if (d->tmp != IRTemp_INVALID)
          retty = typeOfIRTemp(env->type_env, d->tmp);
 
-      /* Throw out any return types we don't know about. */
+      /* Throw out any return types we don't know about.  The set of
+         acceptable return types is the same in both 32- and 64-bit
+         mode, so we don't need to inspect mode64 to make a
+         decision. */
       Bool retty_ok = False;
-      if (mode64) {
-         switch (retty) {
-            case Ity_INVALID: /* function doesn't return anything */
-            case Ity_V128:
-            case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
-               retty_ok = True; break;
-            default:
-               break;
-         }
-      } else {
-         switch (retty) {
-            case Ity_INVALID: /* function doesn't return anything */
-            case Ity_V128:
-            case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
-               retty_ok = True; break;
-            default:
-               break;
-         }
+      switch (retty) {
+         case Ity_INVALID: /* function doesn't return anything */
+         case Ity_V128:
+         case Ity_I64: case Ity_I32: case Ity_I16: case Ity_I8:
+            retty_ok = True; break;
+         default:
+            break;
       }
       if (!retty_ok)
          break; /* will go to stmt_fail: */