]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
libxtables: fix assignment in wrong offset (XTTYPE_UINT*RC)
authorJan Engelhardt <jengelh@medozas.de>
Mon, 2 May 2011 00:43:15 +0000 (02:43 +0200)
committerJan Engelhardt <jengelh@medozas.de>
Sun, 8 May 2011 13:02:22 +0000 (15:02 +0200)
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
xtoptions.c

index 5b1df8897739f25c976ce031c09b0d2c86801648..1cfc8440cf42ba02e915f3381478a3ea69579e88 100644 (file)
@@ -190,7 +190,6 @@ static void xtopt_parse_mint(struct xt_option_call *cb)
                        xt_params->exit_err(PARAMETER_PROBLEM,
                                "%s: Argument to \"--%s\" has unexpected "
                                "characters.\n", cb->ext_name, entry->name);
-               ++cb->nvals;
                if (cb->nvals < ARRAY_SIZE(cb->val.u32_range)) {
                        if (entry->type == XTTYPE_UINT8RC)
                                cb->val.u8_range[cb->nvals] = value;
@@ -201,6 +200,7 @@ static void xtopt_parse_mint(struct xt_option_call *cb)
                        else if (entry->type == XTTYPE_UINT64RC)
                                cb->val.u64_range[cb->nvals] = value;
                }
+               ++cb->nvals;
                if (entry->flags & XTOPT_PUT) {
                        if (entry->type == XTTYPE_UINT8RC)
                                *(uint8_t *)put = value;