]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ldb:pytests: test for Turkic i-dots in ldb_comparison_fold
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 16 Apr 2024 23:42:30 +0000 (11:42 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 23 Apr 2024 01:33:29 +0000 (01:33 +0000)
In tr_TR and some other locales where the letter 'i' uppercases to
'İ', which is not ideal for LDB as we need certain strings like 'guid'
to casefold in the ASCII way.

In fixing https://bugzilla.samba.org/show_bug.cgi?id=15248) we solved
this problem in many cases, but for unindexed searches where the 'i'
is not the last character in the string. This test shows that.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15637

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/tests/python/api.py
selftest/knownfail.d/ldb.python.api.tr [new file with mode: 0644]

index 88dfa8c3b718b2a07a505a4985a6e862c8c80f03..0fc31e3fe09adba15280a771626f7314fcf7a766 100755 (executable)
@@ -1341,6 +1341,22 @@ class SearchTests(LdbBaseTest):
                               expression="(ou=unique)")
         self.assertEqual(len(res11), 1)
 
+    def test_subtree_uni123_elsewhere(self):
+        """Testing a search, where the search term contains a (normal ASCII)
+        dotted-i, that will be upper-cased to 'İ', U+0130, LATIN
+        CAPITAL LETTER I WITH DOT ABOVE in certain locales including
+        tr_TR in which this test is sometimes run.
+
+        The search term should fail because the ou does not exist, but
+        we used to get it wrong in unindexed searches which stopped
+        comparing at the i, ignoring the rest of the string, which is
+        not the same as the existing ou ('123' != 'que').
+        """
+        res11 = self.l.search(base="DC=EXAMPLE,DC=NET",
+                              scope=ldb.SCOPE_SUBTREE,
+                              expression="(ou=uni123)")
+        self.assertEqual(len(res11), 0)
+
     def test_subtree_unique_elsewhere3(self):
         """Testing a search"""
 
diff --git a/selftest/knownfail.d/ldb.python.api.tr b/selftest/knownfail.d/ldb.python.api.tr
new file mode 100644 (file)
index 0000000..f327762
--- /dev/null
@@ -0,0 +1,2 @@
+^ldb.python.api.tr.api.SearchTests.test_subtree_uniquer_elsewhere.none
+^ldb.python.api.tr.api.SearchTestsLmdb.test_subtree_uniquer_elsewhere.none