jobs: Reset jobs as successful if following jobs succeed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/buildservice/jobs.py b/src/buildservice/jobs.py
index 09b6ea3e03e9b11377f8281372f0e06b99774126..170d14ea62127025bafb88affeed06f3471f7ba2 100644 (file)
--- a/src/buildservice/jobs.py
+++ b/src/buildservice/jobs.py
@@ -621,11 +621,15 @@ class Job(base.DataObject):
                # Store message
                self._set_attribute("message", message)
 
-               # Handle any unsuccessful jobs
-               if not success:
-                       # Mark as failed
-                       self._set_attribute("failed", True)
+               # Mark as failed
+               self._set_attribute("failed", not success)
+
+               # On success, update all repositories
+               if success:
+                       await self.build._update_repos()
 
+               # Handle any unsuccessful jobs
+               else:
                        # Notify the owner
                        if self.build.owner:
                                # Send an email
@@ -636,10 +640,6 @@ class Job(base.DataObject):
                                        log=await self.tail_log(100),
                                )
 
-               # On success, update all repositories
-               if success:
-                       await self.build._update_repos()
-
                # Propagate any changes to the build
                return await self.build._job_finished(job=self)