We have faced situation when using CDR and CEL by sqlite3 modules. With system having...

#ASTERISK-23766 #close
Reported by: Igor Goncharovsky

Review: https://reviewboard.asterisk.org/r/3559/
........

Merged revisions 416336 from http://svn.asterisk.org/svn/asterisk/branches/1.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@416337 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/cdr/cdr_sqlite3_custom.c b/cdr/cdr_sqlite3_custom.c
index 601234604298ea884b8479e02dc4d1dc42d8707f..ba318d4507af1d81ad90681c99c17c5016a13b84 100644 (file)
--- a/cdr/cdr_sqlite3_custom.c
+++ b/cdr/cdr_sqlite3_custom.c
@@ -228,7 +228,6 @@ static int write_cdr(struct ast_cdr *cdr)
        int res = 0;
        char *error = NULL;
        char *sql = NULL;
-       int count = 0;
 
        if (db == NULL) {
                /* Should not have loaded, but be failsafe. */
@@ -264,16 +263,7 @@ static int write_cdr(struct ast_cdr *cdr)
                ast_free(value_string);
        }
 
-       /* XXX This seems awful arbitrary... */
-       for (count = 0; count < 5; count++) {
-               res = sqlite3_exec(db, sql, NULL, NULL, &error);
-               if (res != SQLITE_BUSY && res != SQLITE_LOCKED) {
-                       break;
-               }
-               usleep(200);
-       }
-
-       if (error) {
+       if (sqlite3_exec(db, sql, NULL, NULL, &error) != SQLITE_OK) {
                ast_log(LOG_ERROR, "%s. SQL: %s.\n", error, sql);
                sqlite3_free(error);
        }
@@ -315,7 +305,7 @@ static int load_module(void)
                free_config(0);
                return AST_MODULE_LOAD_DECLINE;
        }
-
+       sqlite3_busy_timeout(db, 1000);
        /* is the table there? */
        sql = sqlite3_mprintf("SELECT COUNT(AcctId) FROM %q;", table);
        res = sqlite3_exec(db, sql, NULL, NULL, NULL);

diff --git a/cel/cel_sqlite3_custom.c b/cel/cel_sqlite3_custom.c
index 444df77d3154f26bf77a51e3c9ec26ce2588c58c..ce88be6f733e4acefd27c6df33e15ef3824533c3 100644 (file)
--- a/cel/cel_sqlite3_custom.c
+++ b/cel/cel_sqlite3_custom.c
@@ -231,7 +231,6 @@ static void write_cel(const struct ast_event *event, void *userdata)
 {
        char *error = NULL;
        char *sql = NULL;
-       int count = 0;
 
        if (db == NULL) {
                /* Should not have loaded, but be failsafe. */
@@ -266,18 +265,7 @@ static void write_cel(const struct ast_event *event, void *userdata)
                ast_free(value_string);
        }
 
-       /* XXX This seems awful arbitrary... */
-       for (count = 0; count < 5; count++) {
-               int res = sqlite3_exec(db, sql, NULL, NULL, &error);
-               if (res != SQLITE_BUSY && res != SQLITE_LOCKED) {
-                       break;
-               }
-               usleep(200);
-       }
-
-       ast_mutex_unlock(&lock);
-
-       if (error) {
+       if (sqlite3_exec(db, sql, NULL, NULL, &error) != SQLITE_OK) {
                ast_log(LOG_ERROR, "%s. SQL: %s.\n", error, sql);
                sqlite3_free(error);
        }
@@ -285,6 +273,7 @@ static void write_cel(const struct ast_event *event, void *userdata)
        if (sql) {
                sqlite3_free(sql);
        }
+       ast_mutex_unlock(&lock);
 
        return;
 }
@@ -319,7 +308,7 @@ static int load_module(void)
                free_config();
                return AST_MODULE_LOAD_DECLINE;
        }
-
+       sqlite3_busy_timeout(db, 1000);
        /* is the table there? */
        sql = sqlite3_mprintf("SELECT COUNT(*) FROM %q;", table);
        res = sqlite3_exec(db, sql, NULL, NULL, NULL);

diff --git a/main/db.c b/main/db.c
index b3f9f29f6c670cedaff406664a5cbc09c3d79aa6..0b87ee59b9025a979cc7e79d7130df7d33de739e 100644 (file)
--- a/main/db.c
+++ b/main/db.c
@@ -257,6 +257,7 @@ static int db_open(void)
                ast_mutex_unlock(&dblock);
                return -1;
        }
+
        ast_mutex_unlock(&dblock);
 
        return 0;
@@ -283,9 +284,8 @@ static int db_execute_sql(const char *sql, int (*callback)(void *, int, char **,
        char *errmsg = NULL;
        int res =0;
 
-       sqlite3_exec(astdb, sql, callback, arg, &errmsg);
-       if (errmsg) {
-               ast_log(LOG_WARNING, "Error executing SQL: %s\n", errmsg);
+       if (sqlite3_exec(astdb, sql, callback, arg, &errmsg) != SQLITE_OK) {
+               ast_log(LOG_WARNING, "Error executing SQL (%s): %s\n", sql, errmsg);
                sqlite3_free(errmsg);
                res = -1;
        }

diff --git a/res/res_config_sqlite3.c b/res/res_config_sqlite3.c
index 17b641dfb1f7009333d14e49e57ca1d928359da8..075830df3b306db4da6f3fe324d9eb225ac0e7c5 100644 (file)
--- a/res/res_config_sqlite3.c
+++ b/res/res_config_sqlite3.c
@@ -315,6 +315,7 @@ static int db_open(struct realtime_sqlite3_db *db)
                ao2_unlock(db);
                return -1;
        }
+       sqlite3_busy_timeout(db->handle, 1000);
 
        if (db->debug) {
                sqlite3_trace(db->handle, trace_cb, db);