Revert "value_box_copy() already sets "secret""

This reverts commit 6f19bf204a8f41f48dc5596675b5ce78ecf42cb0.

The user message could be the user name or the password - so this
sets `secret` based on the attribute being created.

diff --git a/src/process/tacacs/base.c b/src/process/tacacs/base.c
index 5c2820e1ae14c911f29869bcad281b441c795614..4dad0bd7e58261bb23f57c982b8e5ed92318027e 100644 (file)
--- a/src/process/tacacs/base.c
+++ b/src/process/tacacs/base.c
@@ -796,6 +796,7 @@ RECV(auth_cont)
 #define EXTRACT(_attr) \
        vp = fr_pair_find_by_da(&request->request_pairs, NULL, attr_tacacs_user_message); \
        if (!vp) break; \
+       fr_value_box_set_secret(&vp->data, _attr->flags.secret); \
        if (pair_append_request(&copy, _attr) < 0) break; \
        if (fr_pair_value_copy(copy, vp) < 0) { \
                fr_pair_remove(&request->request_pairs, copy); \