]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: In rename_internals_fsp(), remove unneeded call to check_name().
authorJeremy Allison <jra@samba.org>
Fri, 10 Dec 2021 00:45:13 +0000 (16:45 -0800)
committerRalph Boehme <slow@samba.org>
Sat, 11 Dec 2021 07:17:28 +0000 (07:17 +0000)
All callers have gone through filename_convert(), which has
already called check_name() on the destination.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index 2623165966fd76700239148e7b1c57e474a2d9f1..1028519b0dcbc03ad94eb9601c6b6e00f399c9aa 100644 (file)
@@ -7190,11 +7190,6 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
        bool case_preserve = (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) ?
                                true : conn->case_preserve;
 
-       status = check_name(conn, smb_fname_dst_in);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
        status = parent_dirname_compatible_open(conn, smb_fname_dst_in);
        if (!NT_STATUS_IS_OK(status)) {
                return status;