Remove realloc call which caused overflow

diff --git a/ChangeLog b/ChangeLog
index a3b8df7c7352ae7210edf2d21e2acaab542c8a54..5748f95e5504711e3ca64e02a29abdd9482daf59 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Mar 21 11:29:06 EST 2007 Daniel P. Berrange <berrange@redhat.com>
+
+       * qemud/buf.c: Remove redundant (and broken) call to realloc()
+       which caused a buffer overflow
+
 Wed Mar 21 16:31:29 CET 2007 Daniel Veillard <veillard@redhat.com>
 
        * qemud/buf.c src/xml.c: clarified virBufferGrow (and bufferGrow)

diff --git a/qemud/buf.c b/qemud/buf.c
index 2ce2462a692d692847a1c2080ea4b6fd68f02376..b3b486664134dad8716537864acf70e93cf8daff 100644 (file)
--- a/qemud/buf.c
+++ b/qemud/buf.c
@@ -118,18 +118,7 @@ bufferFree(bufferPtr buf)
 char *
 bufferContentAndFree (bufferPtr buf)
 {
-    char *content;
-
-    content = buf->content;
-
-    /* Try to reduce the size of the block, but if it fails, it doesn't
-     * matter.
-     */
-    if (buf->use < buf->size) {
-        char *old_content = content;
-        content = realloc (content, buf->use);
-        content = content ? content : old_content;
-    }
+    char *content = buf->content;
 
     free (buf);
     return content;