]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
fix: deduplicate the code for the event listeners
authorDaniel Ruf <daniel@daniel-ruf.de>
Thu, 29 Mar 2018 21:26:19 +0000 (23:26 +0200)
committerDaniel Ruf <daniel@daniel-ruf.de>
Thu, 29 Mar 2018 21:26:19 +0000 (23:26 +0200)
js/foundation.slider.js

index 67dfeb8d08b2967715fe253568b22a10a9c51062..d9e67b11236f73cf9b2bf70daf7684b5ee55d4fe 100644 (file)
@@ -460,20 +460,19 @@ class Slider extends Plugin {
         curHandle,
         timer;
 
+        const handleChangeEvent = function(e) {
+          const idx = _this.inputs.index($(this));
+          _this._handleEvent(e, _this.handles.eq(idx), $(this).val());
+        };
+
       // IE only triggers the change event when the input loses focus which strictly follows the HTML specification
       // listen for the enter key and trigger a change
       // @see https://html.spec.whatwg.org/multipage/input.html#common-input-element-events
       this.inputs.off('keyup.zf.slider').on('keyup.zf.slider', function (e) {
-        if(e.keyCode == 13) {
-          var idx = _this.inputs.index($(this));
-          _this._handleEvent(e, _this.handles.eq(idx), $(this).val());
-        }
+        if(e.keyCode == 13) handleChangeEvent.call(this, e);
       });
 
-      this.inputs.off('change.zf.slider').on('change.zf.slider', function(e) {
-        var idx = _this.inputs.index($(this));
-        _this._handleEvent(e, _this.handles.eq(idx), $(this).val());
-      });
+      this.inputs.off('change.zf.slider').on('change.zf.slider', handleChangeEvent);
 
       if (this.options.clickSelect) {
         this.$element.off('click.zf.slider').on('click.zf.slider', function(e) {