]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: s2mps11: drop two needless variable initialisations
authorAndré Draszik <andre.draszik@linaro.org>
Thu, 22 Jan 2026 15:43:38 +0000 (15:43 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 4 Feb 2026 13:35:33 +0000 (13:35 +0000)
The initialisations being removed are needless, as both variables are
being assigned values unconditionally further down. Additionally, doing
this eager init here might lead to preventing the compiler from issuing
a warning if a future code change actually forgets to assign a useful
value in some code path.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://patch.msgid.link/20260122-s2mpg1x-regulators-v7-11-3b1f9831fffd@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/s2mps11.c

index 04ae9c6150bd5ae9dba47b9b3cfcfb62e4698b6d..1f51fbc6c7b6e158f9707c04d9f030b9eee5e842 100644 (file)
@@ -1207,8 +1207,8 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
        struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent);
        struct regulator_config config = { };
        struct s2mps11_info *s2mps11;
-       unsigned int rdev_num = 0;
-       int i, ret = 0;
+       unsigned int rdev_num;
+       int i, ret;
        const struct regulator_desc *regulators;
 
        s2mps11 = devm_kzalloc(&pdev->dev, sizeof(struct s2mps11_info),