Improve comments in tests `posixsubst*.test'.

* tests/posixsubst-data.test: Improve comment explaining why we
try also empty match suffix.
* tests/posixsubst-extradist.test: Likewise.
* tests/posixsubst-ldadd.test: Likewise.
* tests/posixsubst-libraries.test: Likewise.
* tests/posixsubst-ltlibraries.test: Likewise.
* tests/posixsubst-programs.test: Likewise.
* tests/posixsubst-scripts.test: Likewise.
* tests/posixsubst-sources.test: Likewise.
* tests/posixsubst-tests.test: Likewise.

Suggested by Ralf Wildenhues.

diff --git a/ChangeLog b/ChangeLog
index abeaf005db21ad3f7f7126a22b31a0872a5ca0f5..6a2734771131d2b276efe83f99ff6cd023f3b708 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2010-12-18  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+       Improve comments in tests `posixsubst*.test'.
+       * tests/posixsubst-data.test: Improve comment explaining why we
+       try also empty match suffix.
+       * tests/posixsubst-extradist.test: Likewise.
+       * tests/posixsubst-ldadd.test: Likewise.
+       * tests/posixsubst-libraries.test: Likewise.
+       * tests/posixsubst-ltlibraries.test: Likewise.
+       * tests/posixsubst-programs.test: Likewise.
+       * tests/posixsubst-scripts.test: Likewise.
+       * tests/posixsubst-sources.test: Likewise.
+       * tests/posixsubst-tests.test: Likewise.
+       Suggested by Ralf Wildenhues.
+
 2010-12-16  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 
        Fix typos in test comments.

diff --git a/tests/posixsubst-data.test b/tests/posixsubst-data.test
index f1ffeae3e5e2329736a59dd4691b35e45b3f609a..210279fcea863b07e0fab840f9d546c7ae0c4b7c 100755 (executable)
--- a/tests/posixsubst-data.test
+++ b/tests/posixsubst-data.test
@@ -36,8 +36,8 @@ bar.data bazzardoz:
        : > $@
 CLEANFILES = bar.data bazzardoz
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 dist_foo_DATA = $(t1:=.txt)
 foo_DATA = $(t2:x=.data)
 nodist_foo_DATA = $(t3:.y=zardoz)

diff --git a/tests/posixsubst-extradist.test b/tests/posixsubst-extradist.test
index c3bf970bb08c4cd9f786d480b367079c92fc3bab..c9a20bf669eb2118e161e08ab9d48a42ae8d111e 100755 (executable)
--- a/tests/posixsubst-extradist.test
+++ b/tests/posixsubst-extradist.test
@@ -29,8 +29,8 @@ cat > Makefile.am << 'END'
 t1 = foo1 foo2
 t2 = bar.x
 t3 = baz-y
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 EXTRA_DIST = $(t1:=.c) $(t2:.x=.f) $(t3:-y=ar)
 bazar bar.f:
        : > $@

diff --git a/tests/posixsubst-ldadd.test b/tests/posixsubst-ldadd.test
index fa3a12ca1a93a1780039e1897f6be5b0624cafac..6eb29f93b33116eb71afe4ce54c4625f758eb3d3 100755 (executable)
--- a/tests/posixsubst-ldadd.test
+++ b/tests/posixsubst-ldadd.test
@@ -37,8 +37,8 @@ zardoz_PROGRAMS = foo bar
 
 noinst_LIBRARIES = libquux1.a libquux2.a libquux3.a
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 LDADD = $(u:.lib=.a)
 bar_LDADD = $(v:=.a) libquux2.a $(w:none=libquux3.a)
 

diff --git a/tests/posixsubst-libraries.test b/tests/posixsubst-libraries.test
index 79b96bc25e30a270fbcdbf13c3a31011863d9c57..90cc2e5a5b1c739cb178ce69e4bc3a513e6576a9 100755 (executable)
--- a/tests/posixsubst-libraries.test
+++ b/tests/posixsubst-libraries.test
@@ -32,8 +32,8 @@ cat > Makefile.am << 'END'
 foolibs = libfoo1 libfoo2
 barlibs = libbaz
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 lib_LIBRARIES = $(foolibs:=.a) $(barlibs:z=r.a)
 
 libbar.c:

diff --git a/tests/posixsubst-ltlibraries.test b/tests/posixsubst-ltlibraries.test
index c482db47c573d8b332906de315647c6f202fe4bc..93a1d57363ad97c6cce3ba74d0a99c0e70cb3486 100755 (executable)
--- a/tests/posixsubst-ltlibraries.test
+++ b/tests/posixsubst-ltlibraries.test
@@ -33,8 +33,8 @@ cat > Makefile.am << 'END'
 foolibs = libfoo1 libfoo2
 barlibs = libbaz
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 lib_LTLIBRARIES = $(foolibs:=.la) $(barlibs:z=r.la)
 
 libbar.c:

diff --git a/tests/posixsubst-programs.test b/tests/posixsubst-programs.test
index a8471f627a065b1e1c0f40574b665d16fdae428c..69252dd13bd9e8b76e6d86ec3212ab2123b63396 100755 (executable)
--- a/tests/posixsubst-programs.test
+++ b/tests/posixsubst-programs.test
@@ -30,8 +30,8 @@ cat > Makefile.am << 'END'
 t1 = foo1 foo2
 t2 = barx bar2
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 bin_PROGRAMS = $(t1:=-p) $(t2:2=y)
 
 installcheck-local:

diff --git a/tests/posixsubst-scripts.test b/tests/posixsubst-scripts.test
index a6f253bf9b5ed354facb120c97d8f6f9a71d8795..d5fe91eb0b1cfd957bc7bd0c3a0cd6a0c9307c7d 100755 (executable)
--- a/tests/posixsubst-scripts.test
+++ b/tests/posixsubst-scripts.test
@@ -34,8 +34,8 @@ bar1 bar2 quux.pl:
        : > $@
 CLEANFILES = bar1 bar2 quux.pl
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 dist_sbin_SCRIPTS = $(t1:=.sh)
 libexec_SCRIPTS = $(t2:x=)
 nodist_bin_SCRIPTS = $(t3:-baz=x.pl)

diff --git a/tests/posixsubst-sources.test b/tests/posixsubst-sources.test
index 97f4e55b9b8292ed6c5be1cab84443494b2df47b..14d438d8d821b55b45cf06ca8940802f2acd2a54 100755 (executable)
--- a/tests/posixsubst-sources.test
+++ b/tests/posixsubst-sources.test
@@ -33,8 +33,8 @@ FOO = foo.cxx
 BAR = bar__
 BAZ = baz.
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 foo_SOURCES = main.c $(FOO:.cxx=.c)
 dist_foo_SOURCES = $(BAR:__=.c)
 nodist_foo_SOURCES = $(BAZ:=c)

diff --git a/tests/posixsubst-tests.test b/tests/posixsubst-tests.test
index 98305ae2cfa6860d6f8286c3549a11e3a297cebb..3fca8f4c2ea37cf18fcfaf4547c871d8c376af64 100755 (executable)
--- a/tests/posixsubst-tests.test
+++ b/tests/posixsubst-tests.test
@@ -34,8 +34,8 @@ foo2.test barz:
        (echo '#!/bin/sh' && echo 'exit 0') > $@ && chmod a+x $@
 CLEANFILES = foo2.test barz # for FreeBSD make
 
-# Try also with `:=', to ensure the parser is not unduly confused
-# into thinking that it's an unportable assignment operator.
+# Also try an empty match suffix, to ensure that the `:=' in there is
+# not confused by the parser with an unportable assignment operator.
 TESTS = $(t1:=.test) $(t2:x=y) $(t3:2=z)
 
 EXTRA_DIST = $(TESTS)