]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: amd: sof_amd_sdw: Fix unlikely uninitialized variable use in create_sdw_dailinks()
authorVijendar Mukunda <Vijendar.Mukunda@amd.com>
Tue, 6 May 2025 12:07:23 +0000 (17:37 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:11:13 +0000 (11:11 +0100)
commit 6b83ba4bc3ecb915476d688c9f00f3be57b49a0c upstream.

Initialize current_be_id to 0 in SOF based AMD generic SoundWire machine
driver to handle the unlikely case when there are no devices connected to
a DAI.
In this case create_sdw_dailink() would return without touching the passed
pointer to current_be_id.

Found by gcc -fanalyzer

Cc: stable@vger.kernel.org
Fixes: 6d8348ddc56ed ("ASoC: amd: acp: refactor SoundWire machine driver code")
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://patch.msgid.link/20250506120823.3621604-2-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/amd/acp/acp-sdw-sof-mach.c

index 3be401c7227040569dc7edce6b702c4ac2849742..99a244f495bd30f3166e3191a85a4fe0655b3b4b 100644 (file)
@@ -267,7 +267,7 @@ static int create_sdw_dailinks(struct snd_soc_card *card,
 
        /* generate DAI links by each sdw link */
        while (sof_dais->initialised) {
-               int current_be_id;
+               int current_be_id = 0;
 
                ret = create_sdw_dailink(card, sof_dais, dai_links,
                                         &current_be_id, codec_conf);