]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 2625: Ident: bad read from external lookup buffer
authorAmos Jeffries <squid3@treenet.co.nz>
Mon, 20 Apr 2009 08:48:00 +0000 (20:48 +1200)
committerAmos Jeffries <squid3@treenet.co.nz>
Mon, 20 Apr 2009 08:48:00 +0000 (20:48 +1200)
with thanks to Michael <michael.dotzler@leoni.com> for tracking it down.

src/redirect.cc

index f9142a303e954d25fb7d08f4eb61c44c9c4f2fc3..183f71551a5f6d368be3f945905dd0e18c04f2fe 100644 (file)
@@ -137,7 +137,7 @@ redirectStart(ClientHttpRequest * http, RH * handler, void *data)
 
     if (http->request->auth_user_request)
         r->client_ident = http->request->auth_user_request->username();
-    else if (http->request->extacl_user.buf() != NULL) {
+    else if (http->request->extacl_user.size()) {
         r->client_ident = http->request->extacl_user.buf();
     }