]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: phy: simplify mdiobus_setup_mdiodev_from_board_info
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 11 Jun 2025 20:09:36 +0000 (22:09 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Jun 2025 23:37:23 +0000 (16:37 -0700)
- Move declaration of variable bi into list_for_each_entry_safe()
- The return value of cb() effectively isn't used, this allows to simplify
  the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/f6bbe242-b43d-4c2b-8c51-2cb2cefbaf59@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/mdio-boardinfo.c

index 2de679a681158b6517ddcdd7817eeab5a3a47713..0360c0d08559285bce2ed42c71537040f810c367 100644 (file)
@@ -26,24 +26,18 @@ void mdiobus_setup_mdiodev_from_board_info(struct mii_bus *bus,
                                           (struct mii_bus *bus,
                                            struct mdio_board_info *bi))
 {
-       struct mdio_board_entry *be;
-       struct mdio_board_entry *tmp;
-       struct mdio_board_info *bi;
-       int ret;
+       struct mdio_board_entry *be, *tmp;
 
        mutex_lock(&mdio_board_lock);
        list_for_each_entry_safe(be, tmp, &mdio_board_list, list) {
-               bi = &be->board_info;
+               struct mdio_board_info *bi = &be->board_info;
 
                if (strcmp(bus->id, bi->bus_id))
                        continue;
 
                mutex_unlock(&mdio_board_lock);
-               ret = cb(bus, bi);
+               cb(bus, bi);
                mutex_lock(&mdio_board_lock);
-               if (ret)
-                       continue;
-
        }
        mutex_unlock(&mdio_board_lock);
 }