]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
librpc: Use GUID_buf_string in dcerpc_binding_string()
authorVolker Lendecke <vl@samba.org>
Thu, 31 Dec 2020 09:11:04 +0000 (10:11 +0100)
committerVolker Lendecke <vl@samba.org>
Mon, 11 Jan 2021 14:25:04 +0000 (14:25 +0000)
Avoid a (small) memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Jan 11 14:25:04 UTC 2021 on sn-devel-184

librpc/rpc/binding.c

index 75246dfd5380d9ee9e041e2ef71545e77f897cff..0a78be5bf16d93718711ff3e92c975c64e9c5142 100644 (file)
@@ -227,9 +227,11 @@ _PUBLIC_ char *dcerpc_binding_string(TALLOC_CTX *mem_ctx, const struct dcerpc_bi
        }
 
        if (!GUID_all_zero(&b->object)) {
+               struct GUID_txt_buf buf;
+
                o = s;
-               s = talloc_asprintf_append_buffer(s, "%s@",
-                                   GUID_string(mem_ctx, &b->object));
+               s = talloc_asprintf_append_buffer(
+                       s, "%s@", GUID_buf_string(&b->object, &buf));
                if (s == NULL) {
                        talloc_free(o);
                        return NULL;