]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove superfluous 'pylint: disable' directives
authorŠtěpán Balážik <stepan@isc.org>
Mon, 9 Feb 2026 14:10:36 +0000 (15:10 +0100)
committerŠtěpán Balážik <stepan@isc.org>
Fri, 20 Feb 2026 14:17:32 +0000 (15:17 +0100)
Some of these have been fixed already, fix the rest.

36 files changed:
bin/tests/system/digdelv/yamlget.py
bin/tests/system/doth/stress_http_quota.py
bin/tests/system/isctest/vars/all.py
bin/tests/system/isctest/vars/basic.py
bin/tests/system/isctest/vars/dirs.py
bin/tests/system/keyfromlabel/tests_keyfromlabel.py
bin/tests/system/ksr/tests_ksr.py
bin/tests/system/nsec3/tests_nsec3_change.py
bin/tests/system/nsec3/tests_nsec3_initial.py
bin/tests/system/nsec3/tests_nsec3_reconfig.py
bin/tests/system/nsec3/tests_nsec3_reload.py
bin/tests/system/nsec3/tests_nsec3_restart.py
bin/tests/system/nsec3/tests_nsec3_retransfer.py
bin/tests/system/rollover-algo-csk/tests_rollover_algo_csk_initial.py
bin/tests/system/rollover-algo-csk/tests_rollover_algo_csk_reconfig.py
bin/tests/system/rollover-algo-ksk-zsk/tests_rollover_algo_ksk_zsk_initial.py
bin/tests/system/rollover-algo-ksk-zsk/tests_rollover_algo_ksk_zsk_reconfig.py
bin/tests/system/rollover-csk-roll1/tests_rollover_csk_roll1.py
bin/tests/system/rollover-csk-roll2/tests_rollover_csk_roll2.py
bin/tests/system/rollover-dynamic2inline/tests_rollover_dynamic2inline.py
bin/tests/system/rollover-enable-dnssec/tests_rollover_enable_dnssec.py
bin/tests/system/rollover-going-insecure/tests_rollover_going_insecure_initial.py
bin/tests/system/rollover-going-insecure/tests_rollover_going_insecure_reconfig.py
bin/tests/system/rollover-ksk-3crowd/tests_rollover_three_is_a_crowd.py
bin/tests/system/rollover-ksk-doubleksk/tests_rollover_ksk_doubleksk.py
bin/tests/system/rollover-lifetime/tests_rollover_lifetime_initial.py
bin/tests/system/rollover-lifetime/tests_rollover_lifetime_reconfig.py
bin/tests/system/rollover-multisigner/tests_rollover_multisigner.py
bin/tests/system/rollover-straight2none/tests_rollover_straight2none_initial.py
bin/tests/system/rollover-straight2none/tests_rollover_straight2none_reconfig.py
bin/tests/system/rollover-zsk-prepub/tests_rollover_zsk_prepublication.py
bin/tests/system/tcp/tests_tcp.py
bin/tests/system/timeouts/tests_tcp_timeouts.py
bin/tests/system/tsig/tests_badtime.py
doc/arm/conf.py
doc/man/conf.py

index afa582dd9ceb1ac8914d2ff5b2dbc0f19dae437a..0919c13c603949ddb870e7a56bc95d81127c91ca 100644 (file)
@@ -13,8 +13,7 @@ import sys
 
 try:
     import yaml
-# pylint: disable=bare-except
-except:
+except ImportError:
     print("No python yaml module, skipping")
     sys.exit(1)
 
index 82730c25a5e60901a69baac669717a583c8761a7..70ed382fc6ab528588fb67605c4b5fb999697bc2 100755 (executable)
@@ -135,9 +135,8 @@ class SubDIG:
         return command
 
     def run(self):
-        # pylint: disable=consider-using-with
         with open(os.devnull, "w", encoding="utf-8") as devnull:
-            self.sub_process = subprocess.Popen(
+            self.sub_process = subprocess.Popen(  # pylint: disable=consider-using-with
                 self.get_command(), shell=True, stdout=devnull
             )
 
index ba3f2a3381420d0f4431a23675f68fd9502997c9..a626ee18aeb38d0c052f7c35121b0caf2aebe7a6 100644 (file)
 
 from collections import ChainMap
 
-# pylint: enable=import-error
 from .algorithms import ALG_VARS, CRYPTO_SUPPORTED_VARS
 from .basic import BASIC_VARS
-
-# pylint: disable=import-error
 from .build import BUILD_VARS  # type: ignore
 from .dirs import DIR_VARS
 from .features import FEATURE_VARS
index 683bb600b73cdcd8e2adec168e7ee6cca5e9cd52..6244d665ef698c38986a837660063df4a7b2f080 100644 (file)
 
 import os
 
-# pylint: disable=import-error
 from .build import BUILD_VARS  # type: ignore
 
-# pylint: enable=import-error
-
-
 BASIC_VARS = {
     "ARPANAME": f"{BUILD_VARS['TOP_BUILDDIR']}/arpaname",
     "CDS": f"{BUILD_VARS['TOP_BUILDDIR']}/dnssec-cds",
index 88e8a81c8cbc0d8ad2eb8f026089088b49563dde..7c2becafd92ed257263ca173398b585a04786ea2 100644 (file)
 
 import os
 
-# pylint: disable=import-error
 from .build import BUILD_VARS, SYSTEM_TEST_DIR_GIT_PATH  # type: ignore
 
-# pylint: enable=import-error
-
-
 DIR_VARS = {
     "builddir": f"{BUILD_VARS['TOP_BUILDDIR']}/{SYSTEM_TEST_DIR_GIT_PATH}",
     "srcdir": f"{BUILD_VARS['TOP_SRCDIR']}/{SYSTEM_TEST_DIR_GIT_PATH}",
index b088d431b78b51c9ce2e3bfcdb945274d400af8e..ad3ad0160398509d575f006254413528f98598d2 100644 (file)
@@ -86,7 +86,6 @@ def token_init_and_cleanup():
         assert Re("Found token (.*) with matching token label") in cmd.out
 
 
-# pylint: disable-msg=too-many-locals
 @pytest.mark.parametrize(
     "alg_name,alg_type,alg_bits",
     [
index 6b2cb21b65115b47259622f36ab49c9ee38b895b..e3fbf6dfa2ba829c7f2064ef71c802cfe4386b0d 100644 (file)
@@ -509,7 +509,6 @@ def check_signedkeyresponse(
                 # collect keys that should be in this bundle
                 # collect lines that should be in this bundle
                 bundle_keys.append(key)
-                # pylint: disable=unused-variable
                 for _arg in expected_cds:
                     bundle_lines.append(lines[line_no])
                     line_no += 1
index c8d2dcd42c78d35dd2c2e7824aa6d597e844502f..9b9104cb7f190df643b11d246e0db2b93743d884 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import shutil
 import time
 
index 2133a76265492d8b4ff3d68266b9199ee45ed753..465f11a76eb28cf4e14504f393186feab827a540 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import os
 
 import dns
index e9aa7a6fd44756744969f1881589b0bd0e50f28a..2a0bfecb27468791803e097d1e5a42c6e9ab6511 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import os
 import time
 
index 920a84c31179e8bc5df13311bbf0dace7b1c56b1..fb11f5fc27f3caa5ec7a9b9a7b02c4f9fbf7240e 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import shutil
 
 from nsec3.common import NSEC3_MARK, check_nsec3_case
index 50b67aaef4b36e0d6e5846fc880bac632d52c31f..b553ad120eb75843f7d3e28a57e1ccaa6dc8b787 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import os
 
 import dns
index d1cf0d53aad39ba1476fe24530eca3494b175fea..ff0208593daf5833679303e694d3bec75a205cd7 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import os
index eaa66038ddf031e72418eada2c3a8b30fe9ced83..7126f21766de669e5256d689006b21f2b2e23e46 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.util import param
index afaf9df64a80af629146202a3b20394cc633bf1b..e83763e60127c10dc7507579b7aa64ed854a9efb 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.kasp import KeyTimingMetadata
index f973e3f7f6a4b2a3bfaac8648fb75ff0dc7b1c09..7ad270f0e7e54a3d7d0a59c83dd4e00eb72e17cc 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=unused-import
-
 import pytest
 
 from isctest.util import param
index ffeb539f2fbf3b4d817a1aaf79ab12335f30ac8a..23b57d809469b6496b28cd787f9d68f57c81295f 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.kasp import KeyTimingMetadata
index 70a661abc7db9c120333980d362a9f26b8f9a0e9..49f015218ccf81cfb4cfa72b03a47b59f7a83f1b 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import pytest
index 3e665c44919a54c0cb9c98e0ade2a5cbdce234be..c71a129a0eb1ef9d3131e9d5f077ff0e274b433c 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import pytest
index 9350fe6035a87a56727f51187629dd2082d6b45c..eff0fedc993a5183dcf83fcaf9df7b2850afe7ca 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from rollover.common import CDSS, DEFAULT_CONFIG, ROLLOVER_MARK
 
 import isctest
index cd1ef62e9e16254b5b2316b91fbf7efdf508d160..09a3bf2ee32b98bb8394142e1cb9a816bf02201e 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.kasp import Ipub, IpubC, Iret
index ee4208b08f7368344b66dc4b812ee240a21b21ed..75580655641bd25c3895842025aeec4f10236dae 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from rollover.common import CDSS, DURATION, ROLLOVER_MARK, UNSIGNING_CONFIG
index 4ea02c8654fefdafd1ee12b00b85cc7e46d79b3d..6afa632a3a3859b6ca5db5703352abac622f8d84 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from rollover.common import (
index 3c0fe98cd752c135b7867913a46b4cd3949ead0f..934343919c95bf7ce90516bef5ff004ecc639192 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 from isctest.kasp import KeyTimingMetadata
index d0e750fc9632241893d587b97081bc76cb090aa4..6c7a43e777cd7e323d54bd9157ac652285c33e13 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import pytest
index 9675f0618dc635564d25c8f084a10f3663b2e76a..449d5b8a769dd945b3bce66c68a0e3f7b04dae4a 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.util import param
index aff6c11619fda4c61617426cc2c7b7d370201f00..0576b83d50e17191eac03adebe4d2f8c7f887248 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from isctest.util import param
index 92d1f743ba5f2f80fcc0d4033103564e0f74e154..c0c06f4b61fc5f897a6569929b3238c217021179 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import os
index ab8ffd372ccc603a2f147b5e8e0a815d4738b017..8670193a178caab7abb3b37a8347e30be32eb73f 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from rollover.common import CDSS, DEFAULT_CONFIG, DURATION, ROLLOVER_MARK
index 90ba61af2bd3ba081261e2a63c85fdcf8fb2718d..edab463cd197a6da36d708426eb937ba3acc7153 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 import pytest
 
 from rollover.common import CDSS, DEFAULT_CONFIG, DURATION, ROLLOVER_MARK
index f87827dd21d773decc532fa5a40c857acc10126a..9e2aec2178efd71a2d37b48855c5024df86bca54 100644 (file)
@@ -9,8 +9,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=redefined-outer-name,unused-import
-
 from datetime import timedelta
 
 import pytest
index c8b301f8a87225869980affeaa9245a1ddfea1f0..62d2f45a8c8782dc0e30af866abb833873e8c044 100644 (file)
@@ -11,8 +11,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=unused-variable
-
 import socket
 import struct
 import time
index 5b3e67c6d37dad1ea2f024d02d6515704c737ba6..478c0a345883108ef92284dcff66279fb89c7682 100644 (file)
@@ -11,8 +11,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=unused-variable
-
 import socket
 import time
 
@@ -25,7 +23,7 @@ import dns.rdataclass
 import dns.rdatatype
 import pytest
 
-import isctest.mark  # pylint: disable=import-error
+import isctest.mark
 
 pytestmark = pytest.mark.extra_artifacts(
     [
index 60a47f55cbe4c854b2464a06de82a2dff616b9e5..9981463346ed9049e9b03e49cfa2dd60a8bc2b0d 100644 (file)
@@ -11,8 +11,6 @@
 # See the COPYRIGHT file distributed with this work for additional
 # information regarding copyright ownership.
 
-# pylint: disable=unused-variable
-
 import socket
 import time
 
index f41c27bb907d253685a9414d133bd319119a87eb..3a58eb3fe6d31b74a2cef3a3f7f86cf739ba978a 100644 (file)
@@ -146,7 +146,6 @@ sys.path.append(str(Path(__file__).resolve().parent.parent / "misc"))
 # -- Project information -----------------------------------------------------
 
 project = "BIND 9"
-# pylint: disable=redefined-builtin
 copyright = "2023, Internet Systems Consortium"
 author = "Internet Systems Consortium"
 
index 06431c35f7c97539ffcb0c0c415a8834455a2565..69061eaa4eef069d9c808cb618a8cc7c63b72d47 100644 (file)
@@ -35,11 +35,9 @@ sys.path.append(str(Path(__file__).resolve().parent.parent / "misc"))
 # -- Project information -----------------------------------------------------
 
 project = "BIND 9"
-# pylint: disable=wrong-import-position
 import datetime
 
 year = datetime.datetime.now().year
-# pylint: disable=redefined-builtin
 copyright = "%d, Internet Systems Consortium" % year
 author = "Internet Systems Consortium"
 
@@ -67,7 +65,6 @@ exclude_patterns = [
 # The master toctree document.
 master_doc = "index"
 
-# pylint: disable=line-too-long
 man_pages = [
     (
         "arpaname",