]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix group/mode for /dev/pts inside LXC container
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 22 Feb 2011 14:06:09 +0000 (14:06 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Wed, 23 Feb 2011 11:11:35 +0000 (11:11 +0000)
Normal practice for /dev/pts is to have it mode=620,gid=5
but LXC was leaving mode=000,gid=0 preventing unprivilegd
users in the guest use of PTYs

* src/lxc/lxc_controller.c: Fix /dev/pts setup

src/lxc/lxc_controller.c

index b742a33beb8d53397e66828161574d3163371ced..fa46977afe5638680f21dd92c2fe4ce370c55f4b 100644 (file)
@@ -629,7 +629,8 @@ lxcControllerRun(virDomainDefPtr def,
         }
 
         VIR_DEBUG("Mouting 'devpts' on %s", devpts);
-        if (mount("devpts", devpts, "devpts", 0, "newinstance,ptmxmode=0666") < 0) {
+        if (mount("devpts", devpts, "devpts", 0,
+                  "newinstance,ptmxmode=0666,mode=0620,gid=5") < 0) {
             virReportSystemError(errno,
                                  _("Failed to mount devpts on %s"),
                                  devpts);