Fix missing helper.cc callback check

Calls to cbdataReferenceValidDone() need to be checked for true result
before calling the callback. The pointer may be NULL.

 Detected by Coverity Scan. Issue 1398569.

diff --git a/src/helper.cc b/src/helper.cc
index ae8355c711444ddb24373b4f0045d4d8cbc38e4c..02f4f53b488b1ad3e1e97f6fc1567a914dd063c5 100644 (file)
--- a/src/helper.cc
+++ b/src/helper.cc
@@ -906,8 +906,8 @@ helperReturnBuffer(helper_server * srv, helper * hlp, char * msg, size_t msgSize
                 HLPCB *callback = r->request.callback;
                 r->request.callback = nullptr;
                 void *cbdata = nullptr;
-                cbdataReferenceValidDone(r->request.data, &cbdata);
-                callback(cbdata, r->reply);
+                if (cbdataReferenceValidDone(r->request.data, &cbdata))
+                    callback(cbdata, r->reply);
             }
         }