devlink: require resource parameters

If devlink resource set parameters are not provided it crashes:
$ devlink resource set netdevsim/netdevsim0
Segmentation fault (core dumped)

This is because even though DL_OPT_RESOURCE_PATH and
DL_OPT_RESOURCE_SIZE are passed as o_required, the validation
table doesn't contain a relevant string.

Fixes: 8cd644095842 ("devlink: Add support for devlink resource abstraction")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 5bbe0bddd910ad4616e761d5f203b4fc0e6682e2..056ac95ee726f5733a1af193e4f40163f9edac6b 100644 (file)
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -1121,6 +1121,8 @@ static const struct dl_args_metadata dl_args_required[] = {
        {DL_OPT_DPIPE_TABLE_NAME,     "Dpipe table name expected."},
        {DL_OPT_DPIPE_TABLE_COUNTERS, "Dpipe table counter state expected."},
        {DL_OPT_ESWITCH_ENCAP_MODE,   "E-Switch encapsulation option expected."},
+       {DL_OPT_RESOURCE_PATH,        "Resource path expected."},
+       {DL_OPT_RESOURCE_SIZE,        "Resource size expected."},
        {DL_OPT_PARAM_NAME,           "Parameter name expected."},
        {DL_OPT_PARAM_VALUE,          "Value to set expected."},
        {DL_OPT_PARAM_CMODE,          "Configuration mode expected."},