]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (occ) Fix missing newline in occ_show_extended()
authorSanman Pradhan <psanman@juniper.net>
Thu, 26 Mar 2026 22:45:29 +0000 (22:45 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 30 Mar 2026 20:21:43 +0000 (13:21 -0700)
In occ_show_extended() case 0, when the EXTN_FLAG_SENSOR_ID flag
is set, the sysfs_emit format string "%u" is missing the trailing
newline that the sysfs ABI expects. The else branch correctly uses
"%4phN\n", and all other show functions in this file include the
trailing newline.

Add the missing "\n" for consistency and correct sysfs output.

Fixes: c10e753d43eb ("hwmon (occ): Add sensor types and versions")
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260326224510.294619-3-sanman.pradhan@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/occ/common.c

index ec7dbb94de0b7f7e6307d89d52f2d6f3fd76b5ce..42cc6068bb08be0fb72d99f63cb92e9171656f74 100644 (file)
@@ -724,7 +724,7 @@ static ssize_t occ_show_extended(struct device *dev,
        switch (sattr->nr) {
        case 0:
                if (extn->flags & EXTN_FLAG_SENSOR_ID) {
-                       rc = sysfs_emit(buf, "%u",
+                       rc = sysfs_emit(buf, "%u\n",
                                        get_unaligned_be32(&extn->sensor_id));
                } else {
                        rc = sysfs_emit(buf, "%4phN\n", extn->name);