CVE-2018-16853: Do not segfault if client is not set

This can be triggered with FAST but we don't support this yet.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13571

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source4/kdc/mit-kdb/kdb_samba_policies.c b/source4/kdc/mit-kdb/kdb_samba_policies.c
index 4364461302c29f936e15873dce03553f927c76b1..0b1265980b1fd97728647f3a98aca0071a92af1e 100644 (file)
--- a/source4/kdc/mit-kdb/kdb_samba_policies.c
+++ b/source4/kdc/mit-kdb/kdb_samba_policies.c
@@ -445,6 +445,14 @@ void kdb_samba_db_audit_as_req(krb5_context context,
 {
        struct mit_samba_context *mit_ctx;
 
+       /*
+        * FIXME: This segfaulted with a FAST test
+        * FIND_FAST: <unknown client> for <unknown server>, Unknown FAST armor type 0
+        */
+       if (client == NULL) {
+               return;
+       }
+
        mit_ctx = ks_get_context(context);
        if (mit_ctx == NULL) {
                return;