]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iommufd/selftest: Fix page leaks in mock_viommu_{init,destroy}
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 12 Mar 2026 16:40:42 +0000 (17:40 +0100)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 13 Mar 2026 16:28:40 +0000 (13:28 -0300)
mock_viommu_init() allocates two pages using __get_free_pages(..., 1),
but its error path and mock_viommu_destroy() only release the first page
using free_page(), leaking the second page. Use free_pages() with the
matching order instead to avoid any page leaks.

Fixes: 80478a2b450e ("iommufd/selftest: Add coverage for the new mmap interface")
Link: https://patch.msgid.link/r/20260312164040.457293-3-thorsten.blum@linux.dev
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/selftest.c

index 7823142097d4723bc66bd3e0c811555529eac753..83e2215e7800d05b75902fe98acdb7ee614ca18f 100644 (file)
@@ -636,7 +636,7 @@ static void mock_viommu_destroy(struct iommufd_viommu *viommu)
        if (mock_viommu->mmap_offset)
                iommufd_viommu_destroy_mmap(&mock_viommu->core,
                                            mock_viommu->mmap_offset);
-       free_page((unsigned long)mock_viommu->page);
+       free_pages((unsigned long)mock_viommu->page, 1);
        mutex_destroy(&mock_viommu->queue_mutex);
 
        /* iommufd core frees mock_viommu and viommu */
@@ -870,7 +870,7 @@ err_destroy_mmap:
        iommufd_viommu_destroy_mmap(&mock_viommu->core,
                                    mock_viommu->mmap_offset);
 err_free_page:
-       free_page((unsigned long)mock_viommu->page);
+       free_pages((unsigned long)mock_viommu->page, 1);
        return rc;
 }