]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pwm: imx1: Don't disable clocks at device remove time
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 25 May 2021 06:35:27 +0000 (08:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:02:20 +0000 (16:02 +0200)
[ Upstream commit 1bc6ea31cb41d50302a3c9b401964cf0a88d41f9 ]

The .remove() callback disables clocks that were not enabled in
.probe(). So just probing and then unbinding the driver results in a clk
enable imbalance.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).

Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-imx1.c

index 727e0d3e249ea18eda7041d7f41969034f26cb20..cd48136e5a53b44d118c77990e8b1d7523554ce6 100644 (file)
@@ -169,8 +169,6 @@ static int pwm_imx1_remove(struct platform_device *pdev)
 {
        struct pwm_imx1_chip *imx = platform_get_drvdata(pdev);
 
-       pwm_imx1_clk_disable_unprepare(&imx->chip);
-
        return pwmchip_remove(&imx->chip);
 }