]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 10 Aug 2020 20:23:49 +0000 (22:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Nov 2020 12:39:01 +0000 (13:39 +0100)
[ Upstream commit c81d0b6ca665477c761f227807010762630b089f ]

Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.

Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy <dmurphy@ti.com>
Link: http://lore.kernel.org/r/20201019154233.1262589-10-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/m_can/tcan4x5x.c

index f058bd9104e99f86d2cbfaae4f718672bf35655b..4fdb7121403ab8fb8a8959f4722d62cb4c7d9ae5 100644 (file)
@@ -527,10 +527,10 @@ static int tcan4x5x_can_remove(struct spi_device *spi)
 {
        struct tcan4x5x_priv *priv = spi_get_drvdata(spi);
 
-       tcan4x5x_power_enable(priv->power, 0);
-
        m_can_class_unregister(priv->mcan_dev);
 
+       tcan4x5x_power_enable(priv->power, 0);
+
        return 0;
 }