]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virSecurityManagerMetadataLock: Clarify directory locking comment
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 10 Jul 2020 08:42:01 +0000 (10:42 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 10 Jul 2020 12:06:51 +0000 (14:06 +0200)
In the light of recent commit of 9d83281382 fix the comment that
says directories can't be locked. Well, in general they can, but
not in our case.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/security/security_manager.c

index ad1938caeb069629f7b8d9c1bb6626f7a092f18a..d26d3a05276c575924852015bb8169d3092dfb42 100644 (file)
@@ -1353,7 +1353,8 @@ virSecurityManagerMetadataLock(virSecurityManagerPtr mgr G_GNUC_UNUSED,
             continue;
 
         if (S_ISDIR(sb.st_mode)) {
-            /* Directories can't be locked */
+            /* We need to open the path for writing because we need exclusive
+             * (write) lock. But directories can't be opened for writing. */
             continue;
         }