]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:locking: assert POSIX_LOCK in brl_[un]lock_posix()
authorRalph Boehme <slow@samba.org>
Fri, 7 Mar 2025 13:47:49 +0000 (14:47 +0100)
committerRalph Boehme <slow@samba.org>
Fri, 7 Mar 2025 19:00:32 +0000 (19:00 +0000)
This makes it clearer and prevents possible problems in future.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
source3/locking/brlock.c

index b0295174954b08c409434aa18e80c99b70904327..9b42068a66c6e0fcc890a11a3f4419f478a27f0f 100644 (file)
@@ -757,6 +757,8 @@ static NTSTATUS brl_lock_posix(struct byte_range_lock *br_lck,
        bool break_oplocks = false;
        NTSTATUS status;
 
+       SMB_ASSERT(plock->lock_flav == POSIX_LOCK);
+
        /* No zero-zero locks for POSIX. */
        if (plock->start == 0 && plock->size == 0) {
                return NT_STATUS_INVALID_PARAMETER;
@@ -1024,6 +1026,8 @@ static bool brl_unlock_posix(struct byte_range_lock *br_lck,
        struct lock_struct *locks = br_lck->lock_data;
        bool overlap_found = False;
 
+       SMB_ASSERT(plock->lock_flav == POSIX_LOCK);
+
        /* No zero-zero locks for POSIX. */
        if (plock->start == 0 && plock->size == 0) {
                return False;