Fix obscure memcheck bug found by Nick. This could cause false

negatives, but only in the following unlikely circumstances: for an
8-byte store, which is handled by by the slow path (due to
misalignment or incomplete addressibility).  In this case, the bug
caused the top 32 of the written V bits to be forced to zero
("defined").  This would not have affected the vast majority of 8-byte
stores since almost all of them would either have been handled by the
fast case or would have the top 32 V bits as zero anyway (almost
certainly both).

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@5222

diff --git a/memcheck/mc_main.c b/memcheck/mc_main.c
index 51237ad4495b8c0f85e5e237a978012e05f5b223..e7d8fc31b81a3c81a34a7132fe876acf45cb86c9 100644 (file)
--- a/memcheck/mc_main.c
+++ b/memcheck/mc_main.c
@@ -439,7 +439,7 @@ ULong mc_LOADVn_slow ( Addr a, SizeT szB, Bool bigendian )
 
 
 static 
-void mc_STOREVn_slow ( Addr a, SizeT szB, UWord vbytes, Bool bigendian )
+void mc_STOREVn_slow ( Addr a, SizeT szB, ULong vbytes, Bool bigendian )
 {
    SizeT i;
    SizeT n_addrs_bad = 0;