]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
api.c: Fix strncpy() truncation warning
authorTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:40:39 +0000 (16:40 +0000)
committerTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:40:39 +0000 (16:40 +0000)
Fix the following strncpy() string truncation warning:

In function ‘strncat’,
    inlined from ‘cgroup_get_cgroup’ at api.c:3153:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning: ‘__builtin___strncat_chk’ output may be truncated copying between 0 and 4095 bytes from a string of length 4095 [-Wstringop-truncation]
  136 |   return __builtin___strncat_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/api.c

index 51c4779eaf0f718cbf1a629a2965f29881b9f508..4a980a157cde3f012c4d5f9d917e7623f0160463 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -3151,6 +3151,7 @@ int cgroup_get_cgroup(struct cgroup *cgroup)
 
                path_len = strlen(path);
                strncat(path, cgroup->name, FILENAME_MAX - path_len - 1);
+               path[sizeof(path) - 1] = '\0';
 
                if (access(path, F_OK))
                        continue;