]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK
authorPeter Krempa <pkrempa@redhat.com>
Wed, 16 Feb 2022 12:38:56 +0000 (13:38 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 17 Feb 2022 12:15:46 +0000 (13:15 +0100)
They are features of the RPC; drivers must say that it's not supported.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/driver.c

index 6bebfeba58477fbe56072317086fae7fad54708e..9852a1cb17a335e145887181a34460f7193718ce 100644 (file)
@@ -345,6 +345,11 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
     /* keepalive is handled at RPC level, driver implementations must always
      * return 0, to signal that direct/embedded use doesn't use keepalive */
     case VIR_DRV_FEATURE_PROGRAM_KEEPALIVE:
+    /* Support for close callbacks and remote event filtering are both features
+     * of the RPC protocol and thus normal drivers must not signal support
+     * for them. */
+    case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK:
+    case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK:
         *supported = 0;
         return true;
 
@@ -360,8 +365,6 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
     case VIR_DRV_FEATURE_MIGRATION_PARAMS:
     case VIR_DRV_FEATURE_MIGRATION_DIRECT:
     case VIR_DRV_FEATURE_MIGRATION_V1:
-    case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK:
-    case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK:
     default:
         return false;
     }