]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: ad5398: Fix incorrect power down bit mask
authorDheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Thu, 6 Feb 2025 10:31:53 +0000 (16:01 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 6 Feb 2025 11:27:24 +0000 (11:27 +0000)
AD5398_SW_POWER_DOWN was defined with a bit position outside the valid
range of the device's 16-bit register. The bitwise operation with an
unsigned short would always evaluate to 0, making the power down check
ineffective.

Update AD5398_SW_POWER_DOWN to use a valid bit position within the
16-bit range of the register.

Fixes: 19d022d67d73 ("regulator: ad5398: change enable bit name to improve readibility")
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Link: https://patch.msgid.link/20250206103153.59114-1-dheeraj.linuxdev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/ad5398.c

index 0274f41d0233aa614c9022a4c89b3581db37954a..eb2a666a45cbab9c553975bfc5541fcfb8018646 100644 (file)
@@ -16,7 +16,7 @@
 #include <linux/regulator/machine.h>
 #include <linux/regulator/of_regulator.h>
 
-#define AD5398_SW_POWER_DOWN   BIT(16)
+#define AD5398_SW_POWER_DOWN   BIT(15)
 
 struct ad5398_chip_info {
        struct i2c_client *client;