RDMA/rxe: Improve readability of ODP pagefault interface

Use a meaningful constant explicitly instead of hard-coding a literal.

Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Link: https://patch.msgid.link/20250312065937.1787241-1-matsuda-daisuke@fujitsu.com
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Leon Romanovsky <leon@kernel.org>

diff --git a/drivers/infiniband/sw/rxe/rxe_odp.c b/drivers/infiniband/sw/rxe/rxe_odp.c
index a82e5011360ca53c9fca54e363cc184e4b9d197c..94f7bbe14981c75b5acb90ccaa0dc54d8cedeedb 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_odp.c
+++ b/drivers/infiniband/sw/rxe/rxe_odp.c
@@ -37,8 +37,9 @@ const struct mmu_interval_notifier_ops rxe_mn_ops = {
        .invalidate = rxe_ib_invalidate_range,
 };
 
-#define RXE_PAGEFAULT_RDONLY BIT(1)
-#define RXE_PAGEFAULT_SNAPSHOT BIT(2)
+#define RXE_PAGEFAULT_DEFAULT 0
+#define RXE_PAGEFAULT_RDONLY BIT(0)
+#define RXE_PAGEFAULT_SNAPSHOT BIT(1)
 static int rxe_odp_do_pagefault_and_lock(struct rxe_mr *mr, u64 user_va, int bcnt, u32 flags)
 {
        struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
@@ -222,7 +223,7 @@ int rxe_odp_mr_copy(struct rxe_mr *mr, u64 iova, void *addr, int length,
                    enum rxe_mr_copy_dir dir)
 {
        struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
-       u32 flags = 0;
+       u32 flags = RXE_PAGEFAULT_DEFAULT;
        int err;
 
        if (length == 0)
@@ -236,7 +237,7 @@ int rxe_odp_mr_copy(struct rxe_mr *mr, u64 iova, void *addr, int length,
                break;
 
        case RXE_FROM_MR_OBJ:
-               flags = RXE_PAGEFAULT_RDONLY;
+               flags |= RXE_PAGEFAULT_RDONLY;
                break;
 
        default:
@@ -312,7 +313,8 @@ int rxe_odp_atomic_op(struct rxe_mr *mr, u64 iova, int opcode,
        struct ib_umem_odp *umem_odp = to_ib_umem_odp(mr->umem);
        int err;
 
-       err = rxe_odp_map_range_and_lock(mr, iova, sizeof(char), 0);
+       err = rxe_odp_map_range_and_lock(mr, iova, sizeof(char),
+                                        RXE_PAGEFAULT_DEFAULT);
        if (err < 0)
                return err;