]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata()
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 29 Jul 2025 13:56:39 +0000 (15:56 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 5 Aug 2025 14:05:56 +0000 (16:05 +0200)
Unfortunately when adding sd_cmd_to_sendingdata() in commit
f486bf7d109 we neglected to return any possible error. Fix.

Fixes: f486bf7d109 ("hw/sd/sdcard: Introduce sd_cmd_to_sendingdata and sd_generic_read_byte")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250804133406.17456-2-philmd@linaro.org>

hw/sd/sd.c

index c275fdda2d02a4f2d955cea404fa7cf4e1853b88..0bb385268edac7c3dc99dc0c5f893bb15ec5d466 100644 (file)
@@ -1305,7 +1305,7 @@ static sd_rsp_type_t sd_cmd_to_sendingdata(SDState *sd, SDRequest req,
                                            const void *data, size_t size)
 {
     if (sd->state != sd_transfer_state) {
-        sd_invalid_state_for_cmd(sd, req);
+        return sd_invalid_state_for_cmd(sd, req);
     }
 
     sd->state = sd_sendingdata_state;