]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i40e: remove a stray unlock
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Aug 2016 19:01:07 +0000 (22:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Oct 2016 11:02:09 +0000 (05:02 -0600)
commit be0cb0a66a1d426f7cd9b170c008725044ae147a upstream.

We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.

Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/i40e/i40e_client.c

index 618f18436618945b807c5e08f499dc1a4cd689cf..c65e17fae24e81323506fbcc14eaeaa4378735ad 100644 (file)
@@ -1009,7 +1009,6 @@ int i40e_unregister_client(struct i40e_client *client)
        if (!i40e_client_is_registered(client)) {
                pr_info("i40e: Client %s has not been registered\n",
                        client->name);
-               mutex_unlock(&i40e_client_mutex);
                ret = -ENODEV;
                goto out;
        }