]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: Only mock $INODE64 symbols on x86_64 macOS
authorAndrea Bolognani <abologna@redhat.com>
Thu, 4 Feb 2021 14:48:18 +0000 (15:48 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 10 Feb 2021 10:03:39 +0000 (11:03 +0100)
The version of macOS running on Apple Silicon doesn't need to
concern itself with backwards compatibility with 32-bit
applications, and so it could jettison all the symbol aliasing
shenanigans involved.

https://gitlab.com/libvirt/libvirt/-/issues/121

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Tested-by: Roman Bolshakov <r.bolshakov@yadro.com>
tests/virfilewrapper.c
tests/virmockstathelpers.c
tests/virpcimock.c

index 7034e224207bc5d87891b6dfda615adfe0d3e530..30c63ecf562a50b0149682b91dcef2c843e4d89c 100644 (file)
@@ -56,7 +56,7 @@ static void init_syms(void)
     VIR_MOCK_REAL_INIT(access);
     VIR_MOCK_REAL_INIT(mkdir);
     VIR_MOCK_REAL_INIT(open);
-# ifdef __APPLE__
+# if defined(__APPLE__) && defined(__x86_64__)
     VIR_MOCK_REAL_INIT_ALIASED(opendir, "opendir$INODE64");
 # else
     VIR_MOCK_REAL_INIT(opendir);
index 367c3be95b17dd3215ba3c4d2b452fff2fa60ccb..ecb39bb4f7f1461c1627c15536ea322d91e60151 100644 (file)
@@ -161,7 +161,7 @@ static void virMockStatInit(void)
     debug = getenv("VIR_MOCK_STAT_DEBUG");
 
 #ifdef MOCK_STAT
-# ifdef __APPLE__
+# if defined(__APPLE__) && defined(__x86_64__)
     VIR_MOCK_REAL_INIT_ALIASED(stat, "stat$INODE64");
 # else
     VIR_MOCK_REAL_INIT(stat);
@@ -181,7 +181,7 @@ static void virMockStatInit(void)
     fdebug("real __xstat64 %p\n", real___xstat64);
 #endif
 #ifdef MOCK_LSTAT
-# ifdef __APPLE__
+# if defined(__APPLE__) && defined(__x86_64__)
     VIR_MOCK_REAL_INIT_ALIASED(lstat, "lstat$INODE64");
 # else
     VIR_MOCK_REAL_INIT(lstat);
index f6280fc8b5defd5f51c86fd4d4af5cf58b1fd44b..d1c6220c5751e47be8b2aa371674828a8adfd954 100644 (file)
@@ -936,7 +936,7 @@ init_syms(void)
     VIR_MOCK_REAL_INIT(__open_2);
 # endif /* ! __GLIBC__ */
     VIR_MOCK_REAL_INIT(close);
-# ifdef __APPLE__
+# if defined(__APPLE__) && defined(__x86_64__)
     VIR_MOCK_REAL_INIT_ALIASED(opendir, "opendir$INODE64");
 # else
     VIR_MOCK_REAL_INIT(opendir);