]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[5458] Added a comment for processDhcpv4Query that it doesn't throw.
authorMarcin Siodelski <marcin@isc.org>
Fri, 27 Apr 2018 09:25:06 +0000 (11:25 +0200)
committerMarcin Siodelski <marcin@isc.org>
Fri, 27 Apr 2018 09:25:06 +0000 (11:25 +0200)
src/bin/dhcp6/dhcp6_srv.cc

index 151a3e274bb87f10664faeaca6b84456477efa65..1fb688ccdf486fc1180c16b6366126c3e140c598 100644 (file)
@@ -653,6 +653,8 @@ Dhcpv6Srv::processPacket(Pkt6Ptr& query, Pkt6Ptr& rsp) {
     }
 
     if (query->getType() == DHCPV6_DHCPV4_QUERY) {
+        // This call never throws. Should this change, this section must be
+        // enclosed in try-catch.
         processDhcp4Query(query);
         return;
     }
@@ -3280,7 +3282,7 @@ Dhcpv6Srv::processDhcp4Query(const Pkt6Ptr& dhcp4_query) {
         try {
             // Forward the whole message to the DHCPv4 server via IPC
             Dhcp6to4Ipc::instance().send(dhcp4_query);
-        } catch (const std::exception&) {
+        } catch (...) {
             // Assume the error was already logged
             return;
         }